StatusBarPhaseDisplay Code cleanup #3010
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another cleanup. I couldn't help introduce small changes to the various PhaseDisplays but it's mostly the abstract StatusBarPhaseDisplay.
Note: the statusBarAction which I removed always returned false and was not overridden. I believe it was left over from when the status bar had actions for opening the map and units display (as one of the comments in there said).
No visible changes intended (except for a 1 pixel difference here and there).